Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds better detection of DI classes to global sniff. #239

Open
wants to merge 1 commit into
base: 8.3.x
Choose a base branch
from
Open

Adds better detection of DI classes to global sniff. #239

wants to merge 1 commit into from

Conversation

b-sharpe
Copy link

Fixes #238

klausi
klausi requested changes Dec 28, 2024
View reviewed changes
Copy link
Collaborator

@klausi klausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense!

Please add 2 test cases for the 2 new class names so that we have coverage for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klausi klausi klausi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detection of DI on GlobalDrupalSniff is too loose.
2 participants
@b-sharpe @klausi