Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync include columns with column name changes.#7617 #8348

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RohitBhati8269
Copy link
Contributor

Detail Info:- #7617

@@ -60,6 +60,7 @@ export default class ColumnSchema extends BaseUISchema {
seqcycle: undefined,
colconstype: 'n',
genexpr: undefined,
isInclude: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is required. The problem is with syncing the column names. Normal columns works without any extra variables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The isInclude variable helps track which columns are added to the "Include Column" field in the create table modal, especially when column names change. This works similarly to the is_primary_key variable that tracks columns in the model's column field. This helps maintain proper tracking of column states. Let me know if you'd prefer a different approach!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any is_foreign_key or is_unique_key variables. I don't think it is the right direction.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then what is the use of include_columns key?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants