Allow monitoring non-Heroku databases on Heroku #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we assume that a Heroku-deployed collector will always monitor Heroku databases specified through Heroku env config (`HEROKU_POSTGRES_..._URL` values). It's possible to work around this with `CONFIG_CONTENTS`, but can be an awkward workflow. Allow monitoring databases deployed elsewhere by checking for pganalyze-specific env vars first.
Open
lfittl
approved these changes
Feb 16, 2025
An env-based install can use the default DB_NAME, so we must account for that.
msakrejda
deleted the
allow-monitoring-non-heroku-databases-on-heroku
branch
msakrejda
added a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we assume that a Heroku-deployed collector will always
monitor Heroku databases specified through Heroku env config
(
HEROKU_POSTGRES_..._URLvalues). It's possible to work around thiswith
CONFIG_CONTENTS, but can be an awkward workflow.Allow monitoring databases deployed elsewhere by checking for
pganalyze-specific env vars first.