Add function to normalize only utility statements #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlinsley
commented
Aug 6, 2024
| @@ -96,6 +96,7 @@ extern "C" { | |||
| #endif | |||
|
|
|||
| PgQueryNormalizeResult pg_query_normalize(const char* input); | |||
| PgQueryNormalizeResult pg_query_normalize_utility(const char* input); | |||
There was a problem hiding this comment.
If there's potential for more variants in the future, we should follow the pg_query_parse_opts pattern and use an enum. But unless we want to offer fine-grained normalization (e.g. normalizing specific statement types like SelectStmt), this probably isn't needed.
seanlinsley
changed the title
msakrejda
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
pg_query_normalize_utilityfunction which only normalizes utility statements. We're adding this so the pganalyze collector can redact database secrets from the Postgres logs in the case thatlog_min_duration_statementis set to zero.