Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional that defines ATLEAST_37. #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

morganwahl
Copy link

Hi!

Compilation is failing for me on Python 3.10. It looks like there's some compatibility code for versions before 3.7 vs 3.7 and later. However, the condition to define ATLEAST_37 seems to have the opposite test of what it should.

@pganssle
Copy link
Owner

Is there a reason you need this module on Python 3.10? It's a backport of zoneinfo, which is in the standard library as of Python 3.9.

@morganwahl
Copy link
Author

I don't need it, but I have a dependency which depends on it. It might actually be unused at runtime, but this create problems since it's an error at install time.

Yes, that dependency should update their requirements to not require it on 3.10, but if this makes the install OK on 3.10 it seems like it will save some people a headache.

@morganwahl
Copy link
Author

Actually, digging into my dependencies a little more, I see why I'm hitting this. I'm using pip-tools to generate a requirements.txt, but I generated it using an older Python version, otherwise this wouldn't be in there.

That said, this change seems to make sense, right?

@gsemet
Copy link

gsemet commented Jan 16, 2024

Please make your lib does nothing on 3.10. It is really hard to make some generic purpose package (ex: zipapp with shiv). If zoneinfo needs to be a passthrough on 3.10, let's be it, but do not fail the build !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants