Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for PostgreSQL < 12. #82

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

dwsteele
Copy link
Collaborator

@dwsteele dwsteele commented Aug 1, 2024

These versions are EOL so it make sense to remove them.

@dwsteele dwsteele requested a review from keithf4 August 1, 2024 08:20
@dwsteele dwsteele self-assigned this Aug 1, 2024
src/compatibility.h Show resolved Hide resolved
@keithf4 keithf4 self-requested a review August 1, 2024 18:08
Copy link
Collaborator

@keithf4 keithf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled fine with PG16

Tested with PG11 and it spit out a bunch of errors, but the first one was

keith@dell-laptop:~/Repos/set_user-dsteele$ make install
cat extension/set_user.sql > extension/set_user--4.0.1.sql
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -O2 -fPIC -I. -I./ -I/opt/pgsql1121/include/server -I/opt/pgsql1121/include/internal  -D_GNU_SOURCE   -c -o src/set_user.o src/set_user.c
In file included from src/set_user.c:57:
src/compatibility.h:171:2: error: #error "This extension only builds with PostgreSQL 12 or later"
  171 | #error "This extension only builds with PostgreSQL 12 or later"
      |  ^~~~~
src/compatibility.h:175:1: warning: data definition has no type or storage class
  175 | _PU_HOOK;
      | ^~~~~~~~
src/compatibility.h:175:1: warning: type defaults to ‘int’ in declaration of ‘_PU_HOOK’ [-Wimplicit-int]
[...]

@dwsteele
Copy link
Collaborator Author

dwsteele commented Aug 5, 2024

@keithf4 I do wish I could make that error a little cleaner but not sure how it is possible unless -Wfatal-errors is set and that is up to the user. Anyway, it works.

Thanks for the review!

@dwsteele dwsteele merged commit b89e978 into pgaudit:integration Aug 5, 2024
6 checks passed
@dwsteele dwsteele deleted the dev-compat branch August 5, 2024 02:31
dwsteele added a commit that referenced this pull request Aug 5, 2024
These versions are EOL so it makes sense to remove them.

Reviewed by Keith Fiske (@keithf4).
@dwsteele
Copy link
Collaborator Author

dwsteele commented Aug 5, 2024

I had to recommit this as 1ff48cf since tests failed due to the CI container removing docker compose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants