Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to mention healthcheck #65

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

wuast94
Copy link
Member

@wuast94 wuast94 commented Nov 8, 2024

in respect to #59 (comment)

@justinclift
Copy link
Member

Oh. I was thinking (mistakenly?) that we should be telling people to use the health check script we provide rather than something like pg_isready.

Maybe I need more coffee? 😄

@wuast94
Copy link
Member Author

wuast94 commented Nov 9, 2024

Oh. I was thinking (mistakenly?) that we should be telling people to use the health check script we provide rather than something like pg_isready.

Maybe I need more coffee? 😄

I take one too :P

basicly i added the healthcheck script to the dockerfiles, so the containers have our healthchek build in, no need to declair it.
the reason we mention this in the readme is so that people remove any healthcheck they made or at least give them an intensensive too check what we do becouse if they declaire it the compose or so they would override the built in one

@wuast94
Copy link
Member Author

wuast94 commented Nov 9, 2024

HEALTHCHECK CMD /usr/local/bin/pgautoupgrade-healthcheck.sh

HEALTHCHECK CMD /usr/local/bin/pgautoupgrade-healthcheck.sh

here we alrady bake it in the docker container.

@justinclift
Copy link
Member

Merging this finally. Sorry for taking so long to get to it. 😇

@justinclift justinclift merged commit 3e4dd90 into main Nov 14, 2024
26 checks passed
@justinclift justinclift deleted the wuast94-patch-1 branch November 14, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants