Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After changes to typing in upstream trio, end users have been getting typing errors due to the type on
TaskStatus
. This would've been caught if themypy
test environment hadtrio
as a dependency. So this PR fixes those type errors, updates tox & mypy configs to check againsttrio
, and adds/updates/fixes lots of other minor annotations.This also caught a presumed typo in
"lifspan.startup.complete"
missing an "e" in a test.It doesn't seem great that this project is maintaining its own set of types for the ASGI reference, I've discussed this a bit in django/asgiref#460. If you're up for it I'd love to throw out
src/hypercorn/typing.py
and replace it with a dependency on the asgi-types package (after updating it).Hopefully h11 will push a release so the ~dozen of type errors introduced by that can be ignored: python-hyper/h11#175