Implemented pipeline detection for PGXS and pgrx #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theory
force-pushed
the
detect-pipeline
branch
from
5a82cfa to
c153a24
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 99.25% 99.27% +0.01%
==========================================
Files 7 5 -2
Lines 268 275 +7
==========================================
+ Hits 266 273 +7
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
theory
force-pushed
the
detect-pipeline
branch
4 times, most recently
from
8ed9588 to
00100b8
Compare
The PGXS pipeline examines the Makefile (via regular expressions), while
the pgrx pipeline examines `Cargo.toml` (via the cargo_toml crate). Each
produces a score (0-255), and the highest score wins. If all pipeline
candidates return 0 it returns an error. Now Build::new handles a
pipeline name specified in the release metadata, while Build::detect
figures out which to use when none is specified.
Builder::new now takes a `sudo` param, to indicate whether `sudo` and
passes it to Build::new and Build::detect.
Other tweaks:
* Added an `install` method to the Builder, the Pipeline trait, and
placeholder implementations in the Pgrx and Pgxs implementations.
* Removed the `download` and `unpack` methods from the Builder,
Pipeline trait, and implementations, as the api::Api struct handles
this functionality.
theory
force-pushed
the
detect-pipeline
branch
from
00100b8 to
1386ba9
Compare
vrmiguel
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PGXS pipeline examines the Makefile (via regular expressions), while the pgrx pipeline examines
Cargo.toml(via the cargo_toml crate). Each produces a score (0-255), and the highest score wins. If all pipeline candidates return 0 it returns an error. Now Build::new handles a pipeline name specified in the release metadata, while Build::detect figures out which to use when none is specified.Builder::new now takes a
sudoparam, to indicate whethersudoand passes it to Build::new and Build::detect.Other tweaks:
installmethod to the Builder, the Pipeline trait, andplaceholder implementations in the Pgrx and Pgxs implementations.
downloadandunpackmethods from the Builder,Pipeline trait, and implementations, as the api::Api struct handles
this functionality.