Add api module with download_to method
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theory
force-pushed
the
download
branch
5 times, most recently
from
f006986 to
7434659
Compare
vrmiguel
reviewed
Nov 13, 2024
vrmiguel
reviewed
Nov 14, 2024
| .join("pair-0.1.7.zip"); | ||
|
|
||
| // Start a lightweight mock server. | ||
| let server = MockServer::start(); |
There was a problem hiding this comment.
Cool! Didn't know about this one. I used to use mockito a while back
vrmiguel
reviewed
Nov 14, 2024
src/error/mod.rs
Outdated
| @@ -11,4 +12,30 @@ pub enum BuildError { | |||
| /// Unknown pipeline error. | |||
| #[error("unknown build pipeline `{0}`")] | |||
| UnknownPipeline(String), | |||
|
|
|||
| /// IO rror. | |||
There was a problem hiding this comment.
Bah, fixed in b0f261a, thanks.
vrmiguel
approved these changes
Nov 14, 2024
Use the `ureq` crate for simple synchronous requests, but keep it encapsulated so we can replace it later if need be. Create an agent that supports proxies and require HTTPS for all requests. Use it in the `download_to` method, but if the API base URL has a `file` schema, skip the ureq agent and copy the file directly. This will be useful for working with `rsync`d mirrors. Add variants to the BuildError enum for IO, URL parsing and formatting, and HTTP request errors from ureq. Box ureq errors because otherwise they're far to big, and [clippy complains] about the error size. Make a custom File error to improve IO errors to include the action attempted and relevant file name or names. Use `httpmock` to test the handling of `http:` URLs, and `sha2` & `tempfile` to test `file:` URLs. While at it, exclude `Cargo.lock` from `git diff`; it's just too verbose and distracting. Also use string comparison for some error tests in `src/tests.rs`. [clippy complains]: https://rust-lang.github.io/rust-clippy/master/index.html#result_large_errclippyClick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
ureqcrate for simple synchronous requests, but keep it encapsulated so we can replace it later if need be. Create an agent that supports proxies and require HTTPS for all requests. Use it in thedownload_tomethod, but if the API base URL has afileschema, skip the ureq agent and copy the file directly. This will be useful for working withrsyncd mirrors.Add variants to the BuildError enum for IO, URL parsing and formatting, and HTTP request errors from ureq. Box ureq errors because otherwise they're far to big, and clippy complains about the error size. Make a custom File error to improve IO errors to include the action attempted and relevant file name or names.
Use
httpmockto test the handling ofhttp:URLs, andsha2&tempfileto testfile:URLs.While at it, exclude
Cargo.lockfromgit diff; it's just too verbose and distracting. Also use string comparison for some error tests insrc/tests.rs.