Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenble tls warnings #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jchorl
Copy link

@jchorl jchorl commented Dec 15, 2024

I came across this line disabling TLS warnings.

From the urllib3 docs:

Making unverified HTTPS requests is strongly discouraged, however, if you understand the risks and wish to disable these warnings, you can use disable_warnings()

I blamed the code to 4 years ago, and I couldn't find why this is done: 3097081#diff-0f277423077241e22dbb7aee66e238d101053c903d7c388d0252a11ce1fcdaaeR8

This feels supremely dangerous to put in a public library. Furthermore, I think it can be disabled by setting an env var if someone really needs this functionality: https://stackoverflow.com/a/28002687

Forgive me if I misunderstand the implications of this line of code.

Thanks!

@jchorl
Copy link
Author

jchorl commented Dec 15, 2024

my editor also removed some unnecessary whitespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant