Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce office POI class #29

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

phanecak-maptiler
Copy link
Owner

@phanecak-maptiler phanecak-maptiler commented Dec 15, 2023

This re-implements following OpenMapTiles pull-request into planetiler-openmaptiles:

@phanecak-maptiler
Copy link
Owner Author

Btw, review skipped here, since review in progress in openmaptiles#126 where this was merged.

@wmisener
Copy link

Hi, I think this PR has broken universities (amenity=university in OSM) in OMT, they all appear in the tiles as class=office + subclass=university instead of class=college + subclass=university, which they used to. I think this happened because university can be a value of both amenity=* and office=* in OSM? I'm not super-familiar with how this code works though, but I assume this was unintentional?

@phanecak-maptiler
Copy link
Owner Author

Hi, I think this PR has broken universities (amenity=university in OSM) in OMT, ...

Oh, thanks. Noted here: #31 since this PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants