forked from onthegomap/planetiler
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
215 deterministic ordering v2 #3
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nded to cover features with same keys
…ture.value as some other features
…ce, but given mutlithreading, also randomness between runs)
…deterministic_ordering-plus-215-SortableFeatures-deterministic_value
Since
So as per performance impact, nothing "big" observable so far. |
https://github.com/onthegomap/planetiler/actions/runs/3430072951 ℹ️ Base Logs 0489a29
ℹ️ This Branch Logs f80bba2
|
Looks good, hence closing this PR/experiment. And will op[en new PR (same content, but properly targeting upstream). |
This was referenced Nov 9, 2022
Changes passed to onthegomap#382 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test PR 3: combination of test PR 1 and PR 2
SortableFeature
's encoded valueSortableFeature
sorting to take into account also value whenkey
is the same