Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[When] Add support for flatten_all_tuples=False #1267

Closed
wants to merge 81 commits into from
Closed

[When] Add support for flatten_all_tuples=False #1267

wants to merge 81 commits into from

Commits on May 2, 2023

  1. WIP no flatten all tuples support

    @leonardt
    leonardt committed May 2, 2023
    Configuration menu
    Copy the full SHA
    a6464ab View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Add golds

    @leonardt
    leonardt committed May 3, 2023
    Configuration menu
    Copy the full SHA
    6a69147 View commit details
    Browse the repository at this point in the history

  2. Remove old gold files

    @leonardt
    leonardt committed May 3, 2023
    Configuration menu
    Copy the full SHA
    9a6c205 View commit details
    Browse the repository at this point in the history

  3. Update nested test

    @leonardt
    leonardt committed May 3, 2023
    Configuration menu
    Copy the full SHA
    8778c0d View commit details
    Browse the repository at this point in the history

  4. Update spurious assign test

    @leonardt
    leonardt committed May 3, 2023
    Configuration menu
    Copy the full SHA
    782fb8a View commit details
    Browse the repository at this point in the history

  5. Remove warning code

    @leonardt
    leonardt committed May 3, 2023
    Configuration menu
    Copy the full SHA
    b3f3520 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Update bulk resolve test

    @leonardt
    leonardt committed May 4, 2023
    Configuration menu
    Copy the full SHA
    0df444c View commit details
    Browse the repository at this point in the history

  2. Update nested assign test

    @leonardt
    leonardt committed May 4, 2023
    Configuration menu
    Copy the full SHA
    fd42612 View commit details
    Browse the repository at this point in the history

  3. Update tuple resolve test

    @leonardt
    leonardt committed May 4, 2023
    Configuration menu
    Copy the full SHA
    42f7034 View commit details
    Browse the repository at this point in the history

  4. Refactor code

    @leonardt
    leonardt committed May 4, 2023
    Configuration menu
    Copy the full SHA
    96c1f04 View commit details
    Browse the repository at this point in the history

  5. Add guard

    @leonardt
    leonardt committed May 4, 2023
    Configuration menu
    Copy the full SHA
    2ebedb7 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Merge branch 'master' into fix-1253

    @leonardt
    leonardt committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    17e5913 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Update gold

    @leonardt
    leonardt committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    382edd3 View commit details
    Browse the repository at this point in the history

  2. Add unflattened tuples test for riscv_mini

    @leonardt
    leonardt committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    1d9e0ea View commit details
    Browse the repository at this point in the history

  3. Disallow local variables

    @leonardt
    leonardt committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    58a15ca View commit details
    Browse the repository at this point in the history

  4. Add lint check

    @leonardt
    leonardt committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    00144ff View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Sort tuple keys

    @leonardt
    leonardt committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7fb783f View commit details
    Browse the repository at this point in the history

  2. Fix style

    @leonardt
    leonardt committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    04fa396 View commit details
    Browse the repository at this point in the history

  3. Add API for sorting

    @leonardt
    leonardt committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    65539cc View commit details
    Browse the repository at this point in the history

  4. Fix API bug

    @leonardt
    leonardt committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d19d34a View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. WIP xmr support

    @leonardt
    leonardt committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    c6d802d View commit details
    Browse the repository at this point in the history

  2. Set path string based on opts

    @leonardt
    leonardt committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    54eed7e View commit details
    Browse the repository at this point in the history

  3. Update compile opts

    @leonardt
    leonardt committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    3ced6ad View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Update inline_verilog2 test to parametrize flatten

    @leonardt
    leonardt committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    5e0d4b5 View commit details
    Browse the repository at this point in the history

  2. Add missing gold file

    @leonardt
    leonardt committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    a9912cd View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Test tile instead of core for more coverage

    @leonardt
    leonardt committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    8b881ba View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Fix gold

    @leonardt
    leonardt committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d087af5 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Rename i to key

    @leonardt
    leonardt committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    254c2d7 View commit details
    Browse the repository at this point in the history

  2. Update keyerror message

    @leonardt
    leonardt committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    cb4711a View commit details
    Browse the repository at this point in the history

  3. Formatting

    @leonardt
    leonardt committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6014503 View commit details
    Browse the repository at this point in the history

  4. comments

    @leonardt
    leonardt committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3b5232c View commit details
    Browse the repository at this point in the history

  5. Formatting

    @leonardt
    leonardt committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    149d70b View commit details
    Browse the repository at this point in the history

  6. Formatting

    @leonardt
    leonardt committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    43a593d View commit details
    Browse the repository at this point in the history

  7. Formatting

    @leonardt
    leonardt committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    0a018cd View commit details
    Browse the repository at this point in the history

  8. flatten -> flatten_all_tuples

    @leonardt
    leonardt committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6077ab3 View commit details
    Browse the repository at this point in the history

  9. Fix API call

    @leonardt
    leonardt committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c8f1d41 View commit details
    Browse the repository at this point in the history

  10. Revert change

    @leonardt
    leonardt committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d47bc35 View commit details
    Browse the repository at this point in the history

  11. Revert debug change

    @leonardt
    leonardt committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5fbae01 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Formatting

    @leonardt
    leonardt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d73144a View commit details
    Browse the repository at this point in the history

  2. flatten -> flatten_all_tuples

    @leonardt
    leonardt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    64fd692 View commit details
    Browse the repository at this point in the history

  3. Comment

    @leonardt
    leonardt committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    53530e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Add tuple key ordering test

    @leonardt
    leonardt committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    23a868a View commit details
    Browse the repository at this point in the history

  2. Fix iter logic for children with different key orders

    @leonardt
    leonardt committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ba5f24d View commit details
    Browse the repository at this point in the history

  3. [Array] Fix E721 from pycodestyle 

    Should use isinstance check instead of `is` for types
    @leonardt
    leonardt committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ab04c1d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix-1253

    @leonardt
    leonardt committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    62d3b83 View commit details
    Browse the repository at this point in the history

  5. Update gold

    @leonardt
    leonardt committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    f768881 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Merge remote-tracking branch 'origin/master' into fix-1253

    @leonardt
    leonardt committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    d16742a View commit details
    Browse the repository at this point in the history

  2. Add support for emit when assertions

    @leonardt
    leonardt committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    41c9289 View commit details
    Browse the repository at this point in the history

  3. Fix default argument

    @leonardt
    leonardt committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    5e97d99 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into fix-1253

    @leonardt
    leonardt committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    08a909f View commit details
    Browse the repository at this point in the history

  5. Update gold

    @leonardt
    leonardt committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    0e301b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Resolve unsanitized xmr issue

    @leonardt
    leonardt committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    40a7348 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Revert "Resolve unsanitized xmr issue" 

    This reverts commit 40a7348.
    @leonardt
    leonardt committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    b9e4cfc View commit details
    Browse the repository at this point in the history

  2. Fix xmr with integer key

    @leonardt
    leonardt committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    83219f1 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Add disallowPackedStructAssignments opts

    @leonardt
    leonardt committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    7cb2321 View commit details
    Browse the repository at this point in the history

  2. Update test

    @leonardt
    leonardt committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    da898c7 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Merge branch 'master' into fix-1253

    @leonardt
    leonardt committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    27854f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Add missing gold

    @leonardt
    leonardt committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    5902cc5 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. [Types] Disallow wiring different order tuples

    @rsetaluri
    rsetaluri committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    b0b7eb4 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Address review comments

    @leonardt
    leonardt committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    07ff1ef View commit details
    Browse the repository at this point in the history

  2. update compile to mlir opts

    @leonardt
    leonardt committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    3c564c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Merge branch 'master' into fix-1253

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    7768ee2 View commit details
    Browse the repository at this point in the history

  2. Update gold version

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    60a19a5 View commit details
    Browse the repository at this point in the history

  3. Add test covering tuple key ordering

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5f1a864 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'types-disallow-wiring-different-order-tuples' into fix-… 

    …1253
    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    e1b41c6 View commit details
    Browse the repository at this point in the history

  5. Remove tuple ordering test

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    06bb3da View commit details
    Browse the repository at this point in the history

  6. Remove sorting logic

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    fa269e6 View commit details
    Browse the repository at this point in the history

  7. Revert ordering change

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    21ffb92 View commit details
    Browse the repository at this point in the history

  8. Update struct ordering

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    09b0b0e View commit details
    Browse the repository at this point in the history

  9. [Tuple] Add recursive wiring key ordering check 

    Fixes #1316

Ensures that recursive types check tuple key ordering
    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    58393a1 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'tuple-order-recursive' into fix-1253

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5838dff View commit details
    Browse the repository at this point in the history

  11. Fix field logic bug

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1256d95 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'tuple-order-recursive' into fix-1253

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    ddcef99 View commit details
    Browse the repository at this point in the history

  13. Fix elab issue

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    f1e96db View commit details
    Browse the repository at this point in the history

  14. Merge branch 'tuple-order-recursive' into fix-1253

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    9e6f537 View commit details
    Browse the repository at this point in the history

  15. Fix index logic

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    8cd81d9 View commit details
    Browse the repository at this point in the history

  16. Use .fields

    @leonardt
    leonardt committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    ecdea05 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. [Bind2] Add support for compile guard around bind (#1315) 

    * [Bind2] Separate return statements

* [Bind2] Remove compile_guard argument

* [CompileGuard] Store compile guard info directly

* [CompileGuard] Expose active compile guards

* [Bind2] Stash active compile guards

Attaches active compile guard info's to bound instance metadata.

* [Bind2] Add tests for compile guarded bind2()

* [MLIR] Print attr_dict for sv.IfDefOp

* [MLIR] Add MlirOp.parent_op() function

* [MLIR] Add support for bind2 wrapped in compile guard

* Emit sv.IfDefOp around sv.BindOp
* Attach hw.OutputFileAttr for entire sub-tree of op's surrounding
  sv.BindOp (all enclosing sv.IfDefOp, and including sv.BindOp).
* Add generic MlirOpPass infrastructure

* [CompileGuard] Fix test

* [MLIR] Update golds

* [MLIR] Use := in MlirOp.parent_op()

* [MLIR] Make MlirOpPass callable interface

* [CompileGuard] Use Stack iterable interface

* [Bind2] Use getattr to get bound inst info
    @rsetaluri
    rsetaluri authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    07f4cb8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:phanrahan/magma into fix-1253

    @leonardt
    leonardt committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    bb4dbb0 View commit details
    Browse the repository at this point in the history

  3. [When] Split when blocks with cycles (#1309) 

    Fixes #1269

Adds a pass that splits when blocks with a cyclic dependency.
    @leonardt
    leonardt authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    512c7e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Revert "[When] Split when blocks with cycles (#1309)" 

    This reverts commit 512c7e1.
    @rsetaluri
    rsetaluri committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    ad05e7e View commit details
    Browse the repository at this point in the history