[Bind2] Add support for compile guard around bind #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1315 +/- ##
==========================================
+ Coverage 85.95% 86.00% +0.04%
==========================================
Files 169 170 +1
Lines 17727 17810 +83
==========================================
+ Hits 15237 15317 +80
- Misses 2490 2493 +3
☔ View full report in Codecov by Sentry. |
leonardt
requested changes
Sep 14, 2023
Attaches active compile guard info's to bound instance metadata.
* Emit sv.IfDefOp around sv.BindOp * Attach hw.OutputFileAttr for entire sub-tree of op's surrounding sv.BindOp (all enclosing sv.IfDefOp, and including sv.BindOp). * Add generic MlirOpPass infrastructure
rsetaluri
force-pushed
the
bind2-add-compile-guard
branch
from
bbbf8ff to
93061b6
Compare
leonardt
approved these changes
Sep 22, 2023
rsetaluri
added a commit
that referenced
this pull request
Sep 22, 2023
Adds support for emitting `ifdef` around `bind` calls. The syntax for
this is:
```python
with m.compile_guard(...):
m.bind2(...)
```
which emits MLIR like:
```MLIR
sv.ifdef ... {
sv.bind ...
}
```
```Verilog
`ifdef ...
bind ...
`endif
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for emitting
ifdefaroundbindcalls. The syntax for this is:which emits MLIR like:
One important thing to note is that in the case of split verilog, the output file attribute annotation has to be applied up the compile guard stack, i.e. the
sv.ifdefsurrounding thesv.bindalso needs thehw.OutputFileAttrattached.