[Circuit] Support mutable IO #1351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsetaluri
force-pushed
the
circuit-allow-mutable-io
branch
from
36b16ee
to
5189d9b
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1351 +/- ##
==========================================
- Coverage 85.24% 85.22% -0.02%
==========================================
Files 169 169
Lines 17617 17624 +7
==========================================
+ Hits 15017 15020 +3
- Misses 2600 2604 +4 ☔ View full report in Codecov by Sentry. |
leonardt
requested changes
Jan 26, 2024
Comment on lines
+479
to
+482
| if self._bound or other._bound: | ||
| raise Exception("Adding bound IO not allowed") | ||
| if self._ports.keys() & other._ports.keys(): | ||
| raise Exception("Adding IO with duplicate port names not allowed") |
There was a problem hiding this comment.
Should move this to a helper function so it can share code with __iadd__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1349.