Add to acceptable fields as per commercial tracking doc #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DhiaPhntm
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
seriously questioning this validator I put in as each site has different interpretations of the field values, lets get it in for now if it validates for now.
FYI i've updated the test nodejs versions to 16,18 in the other PR - 12 is always failing now probably due to lack of syntax support in some dep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.google.com/spreadsheets/d/1tghJANuygEkpvLztr0qeRyz13dRQbbqATwYHZlqauCs/edit#gid=452162634