Merge pull request #141 from ThomasWeinert/feature/improved-bat-phar-…

…activator Improved BatPharActivator
phar-io · May 5, 2018 · a1a4a31 · a1a4a31
2 parents ed9356e + cd9173f
commit a1a4a31
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 1 deletion.
diff --git a/src/shared/file/BatPharActivator.php b/src/shared/file/BatPharActivator.php
@@ -21,10 +21,19 @@ public function __construct($template) {
      * @param Filename $linkDestination
      *
      * @return Filename
+     * @throws FileNotWritableException
      */
     public function activate(Filename $pharLocation, Filename $linkDestination) {
-        $template = str_replace(self::PHAR_PLACEHOLDER, $pharLocation->asString(), $this->template);
         $linkFilename = new Filename($linkDestination->asString() . '.bat');
+        if (!$linkDestination->getDirectory()->isWritable()) {
+            throw new FileNotWritableException(sprintf('File %s is not writable.', $linkFilename->asString()));
+        }
+        if ((string)$pharLocation->getDirectory() === (string)$linkFilename->getDirectory()) {
+            $pathToPhar = '%~dp0' . $pharLocation->getRelativePathTo($linkFilename->getDirectory())->asString();
+        } else {
+            $pathToPhar = $pharLocation->asString();
+        }
+        $template = str_replace(self::PHAR_PLACEHOLDER, $pathToPhar, $this->template);
         file_put_contents($linkFilename, $template);
 
         return $linkFilename;

diff --git a/tests/unit/shared/file/BatPharActivatorTest.php b/tests/unit/shared/file/BatPharActivatorTest.php
@@ -1,6 +1,7 @@
 <?php
 namespace PharIo\Phive;
 
+use PharIo\FileSystem\Directory;
 use PharIo\FileSystem\Filename;
 use PHPUnit\Framework\TestCase;
 
@@ -16,6 +17,38 @@ public function testCreatesExpectedBatFile() {
         $this->assertEquals('foo some.phar bar', file_get_contents($createdFile));
     }
 
+    public function testCreatesExpectedBatFileWithPath() {
+        $activator = new BatPharActivator('foo ##PHAR_FILENAME## bar');
+        $createdFile = $activator->activate(
+           new Filename(__DIR__ . '/path/some.phar'),
+           new Filename(__DIR__ . '/some')
+        );
+
+        $this->assertEquals('foo ' . __DIR__ . '/path/some.phar bar', file_get_contents($createdFile));
+    }
+
+    public function testCreatesExpectedBatFileWithPathPlaceholder() {
+        $activator = new BatPharActivator('foo ##PHAR_FILENAME## bar');
+        $createdFile = $activator->activate(
+           new Filename(__DIR__ . '/some.phar'),
+           new Filename(__DIR__ . '/some')
+        );
+
+        $this->assertEquals('foo %~dp0some.phar bar', file_get_contents($createdFile));
+    }
+
+    public function testDestinationNotWritableExpectingException() {
+        $directory = $this->createMock(Directory::class);
+        $directory->expects($this->any())->method('isWritable')->willReturn(FALSE);
+        $destination = $this->createMock(Filename::class);
+        $destination->expects($this->any())->method('getDirectory')->willReturn($directory);
+
+        $this->expectException(FileNotWritableException::class);
+
+        $activator = new BatPharActivator('foo ##PHAR_FILENAME## bar');
+        $activator->activate(new Filename('some.phar'), $destination);
+    }
+
     protected function tearDown() {
         if (file_exists(__DIR__ . '/some.bat')) {
             unlink(__DIR__ . '/some.bat');