106 table 09 gt@main #126

mattkorb · 2023-09-21T07:00:06Z

Pull Request

Closes #106

mattkorb · 2023-09-21T07:03:08Z

I know that the files for the webpage still need to be updated. I just wanted to already create th PR so that someone reviews the code.

…into 106_table_09_gt@main

github-actions · 2023-10-31T16:35:33Z

Code Coverage Summary

Filename            Stmts    Miss  Cover    Missing
----------------  -------  ------  -------  ---------
R/fda-table_02.R      159       0  100.00%
R/fda-table_03.R       35       0  100.00%
R/fda-table_04.R       63       0  100.00%
R/fda-table_05.R       61       0  100.00%
R/fda-table_06.R       76       0  100.00%
R/fda-table_07.R       35       0  100.00%
R/fda-table_08.R       46       0  100.00%
R/fda-table_09.R      214       0  100.00%
R/fda-table_10.R       26       0  100.00%
R/fda-table_11.R       42       0  100.00%
R/fda-table_12.R       40       0  100.00%
R/fda-table_13.R       20       0  100.00%
R/fda-table_14.R       27       0  100.00%
R/fda-table_15.R       32       0  100.00%
R/fda-table_16.R       32       0  100.00%
R/fda-table_17.R       32       0  100.00%
R/fda-table_18.R       32       0  100.00%
R/fda-table_20.R       71       0  100.00%
R/fda-table_21.R       78       0  100.00%
R/fda-table_32.R       71       0  100.00%
R/fda-table_33.R       30       0  100.00%
R/fda-table_34.R       30       0  100.00%
R/utils.R              31       0  100.00%
TOTAL                1283       0  100.00%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  --------
R/fda-table_09.R     +180       0  +100.00%
TOTAL                +180       0  +100.00%

Results for commit: b30ce60

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

…into 106_table_09_gt@main

ayogasekaram · 2023-10-31T18:40:58Z

hey @mattkorb! Looking great so far. I pushed a few changes after merging the updates from main into the branch. It looks like a couple of the checks are failing (like lintr). Would you be able to resolve those in the mean time? I'll take a look at it again afterwards. Thanks!

mattkorb · 2023-11-02T16:13:19Z

hey @ayogasekaram thank you for the review :)
I will take a look at the failing checks and will let you know once they are resolved.

…too)

github-actions · 2023-11-03T17:46:42Z

Unit Tests Summary

    1 files   22 suites 44s ⏱️
  85 tests   85 ✔️   0 💤 0 ❌
343 runs 258 ✔️ 85 💤 0 ❌

Results for commit b30ce60.

♻️ This comment has been updated with latest results.

ayogasekaram

lgtm @mattkorb!

* Add Resources page to website (#154) * [skip actions] Bump version to 0.1.0.9044 * markdown table update (#158) Closes #157 * [skip actions] Bump version to 0.1.0.9045 * 106 table 09 gt@main (#126) * Add make_table_09_gt function * Add option to add overall column * Clean up code and rename functions * Remove explicit function calls * Add risk differnce calculations * Update risk_diff documentation * Update table 09 website page * Redocument package * Add tests for make_table_09_gt * [skip actions] Restyle files * Update function name and tests * [skip actions] Restyle files * update man pages. * apply formatters new line changes. * [skip actions] Restyle files * [skip actions] Roxygen Man Pages Auto Update * Solve lintr marks * [skip actions] Restyle files * updates for build cmd check. (correcting table 15, 16, 17, 18 params too) * [skip actions] Restyle files * updates for cmd check * update function name in quarto docs * Update rtables version --------- Co-authored-by: Abinaya Yogasekaram <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ayogasekaram <[email protected]> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Emily de la Rua <[email protected]> --------- Co-authored-by: Emily de la Rua <[email protected]> Co-authored-by: edelarua <[email protected]> Co-authored-by: Korbinian Matthias <[email protected]> Co-authored-by: Abinaya Yogasekaram <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ayogasekaram <[email protected]> Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Emily de la Rua <[email protected]>

mattkorb added 5 commits September 4, 2023 14:41

Add make_table_09_gt function

071da81

Add option to add overall column

42cea29

Clean up code and rename functions

88d30d8

Remove explicit function calls

3f11327

Add risk differnce calculations

0a229a7

mattkorb and others added 11 commits October 6, 2023 14:56

Update risk_diff documentation

0ceced0

Update table 09 website page

dcb7165

Redocument package

bc82183

Add tests for make_table_09_gt

fc0ae0b

Merge branch 'main' into 106_table_09_gt@main

30ae280

Merge 30ae280 into b43a142

10ea03c

[skip actions] Restyle files

753a604

Update function name and tests

e140fb0

Merge branch '106_table_09_gt@main' of github.com:pharmaverse/falcon …

cbcab61

…into 106_table_09_gt@main

Merge cbcab61 into b43a142

a9a0cd8

[skip actions] Restyle files

dfd8f9d

ayogasekaram and others added 4 commits October 31, 2023 17:59

update man pages.

539bbd7

Merge branch '106_table_09_gt@main' of github.com:pharmaverse/falcon …

0f91bba

…into 106_table_09_gt@main

apply formatters new line changes.

7a362a4

Merge 0f91bba into b43a142

1446bfe

ayogasekaram self-requested a review October 31, 2023 18:26

github-actions bot and others added 3 commits October 31, 2023 18:28

[skip actions] Restyle files

4fe2ae9

Merge branch '106_table_09_gt@main' of github.com:pharmaverse/falcon …

a86903b

…into 106_table_09_gt@main

[skip actions] Roxygen Man Pages Auto Update

3807de8

mattkorb and others added 2 commits November 3, 2023 14:50

Solve lintr marks

8dda0bb

Merge 8dda0bb into ad0e968

a4614d9

github-actions bot and others added 7 commits November 3, 2023 13:52

[skip actions] Restyle files

5e42369

updates for build cmd check. (correcting table 15, 16, 17, 18 params …

b053be1

…too)

Merge b053be1 into ad0e968

0714e7f

[skip actions] Restyle files

4514836

updates for cmd check

32462f5

update function name in quarto docs

0083add

Update rtables version

014aea3

ayogasekaram approved these changes Nov 3, 2023

View reviewed changes

Merge branch 'main' into 106_table_09_gt@main

b30ce60

mattkorb merged commit 1be2a7d into main Nov 10, 2023

mattkorb deleted the 106_table_09_gt@main branch November 10, 2023 11:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

106 table 09 gt@main #126

106 table 09 gt@main #126

mattkorb commented Sep 21, 2023

mattkorb commented Sep 21, 2023

github-actions bot commented Oct 31, 2023 •

edited

Loading

ayogasekaram commented Oct 31, 2023

mattkorb commented Nov 2, 2023

github-actions bot commented Nov 3, 2023 •

edited

Loading

ayogasekaram left a comment

106 table 09 gt@main #126

106 table 09 gt@main #126

Conversation

mattkorb commented Sep 21, 2023

Pull Request

mattkorb commented Sep 21, 2023

github-actions bot commented Oct 31, 2023 • edited Loading

Code Coverage Summary

Diff against main

ayogasekaram commented Oct 31, 2023

mattkorb commented Nov 2, 2023

github-actions bot commented Nov 3, 2023 • edited Loading

Unit Tests Summary

ayogasekaram left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 31, 2023 •

edited

Loading

github-actions bot commented Nov 3, 2023 •

edited

Loading