Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

128 new table table 15 #150

Merged
merged 11 commits into from
Nov 2, 2023
Merged

128 new table table 15 #150

merged 11 commits into from
Nov 2, 2023

Conversation

huanlugwu
Copy link
Collaborator

Pull Request

Closes #128

huanlugwu and others added 2 commits October 16, 2023 17:20
@huanlugwu @edelarua
@github-actions @dependabot-preview @ayogasekaram
branch update (#148)
2f2080c 
* General package updates/maintenance (#116)

* [skip actions] Bump version to 0.1.0.9032

* Add more questions to FAQ (#132)

* [skip actions] Bump version to 0.1.0.9033

* Change `gtsummary` table function suffix (#131)

* [skip actions] Bump version to 0.1.0.9034

* Update all `pref_var` parameters to `AEDECOD` (#134)

Update pref_var to AEDECOD

* [skip actions] Bump version to 0.1.0.9035

* Updates after `tern` 0.9.0 CRAN release (#121)

* [skip actions] Bump version to 0.1.0.9036

* Fix typo in FAQ (#137)

Fix typo

* [skip actions] Bump version to 0.1.0.9037

* 93 table 3 patient screening and enrollment trials a and b (#127)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Emily de la Rua <[email protected]>
Co-authored-by: Emily de la Rua <[email protected]>

* [skip actions] Bump version to 0.1.0.9038

* Remove hard-coding of `"SAFFL"` (#143)

* [skip actions] Bump version to 0.1.0.9039

* Update README (#140)

* [skip actions] Bump version to 0.1.0.9040

* Update Presentations section (#145)

* [skip actions] Bump version to 0.1.0.9041

* Add `saffl_var` to function template pages (#147)

* [skip actions] Bump version to 0.1.0.9042

* 130 table 02 updates@main (#138)

* update gt tests for table 2

* change summarize_vars to analyze_vars

* table 02 updates.

* [skip actions] Restyle files

* Update function reference links

* revert test snapshots

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Emily de la Rua <[email protected]>
Co-authored-by: Emily de la Rua <[email protected]>

---------

Co-authored-by: Emily de la Rua <[email protected]>
Co-authored-by: edelarua <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Emily de la Rua <[email protected]>
Co-authored-by: Abinaya Yogasekaram <[email protected]>
@huanlugwu
created table 15, 16, 17 and 18
e146edf
@huanlugwu huanlugwu linked an issue Oct 17, 2023 that may be closed by this pull request
[New Table]: Table 15, 16, 17 and 18 #128
Closed
8 tasks
@huanlugwu huanlugwu requested a review from edelarua October 17, 2023 08:24
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023 •
edited
Loading

Unit Tests Summary

    1 files    22 suites   1m 4s ⏱️
  83 tests   83 ✔️   0 💤 0 ❌
339 runs  256 ✔️ 83 💤 0 ❌

Results for commit 2d58b5c.

♻️ This comment has been updated with latest results.

@edelarua edelarua self-assigned this Oct 31, 2023
edelarua
edelarua approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @huanlugwu!

I just modified the example data a bit and added a filter to only include sex-specific FMQs. One thing to note for the future: make sure not to hard-code adsl as the default for alt_counts_df since this variable should be optional/specified by the user in all tables. Other than that, fantastic job!

Thanks!! :)

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename            Stmts    Miss  Cover    Missing
----------------  -------  ------  -------  ---------
R/fda-table_02.R      159       0  100.00%
R/fda-table_03.R       35       0  100.00%
R/fda-table_04.R       63       0  100.00%
R/fda-table_05.R       61       0  100.00%
R/fda-table_06.R       76       0  100.00%
R/fda-table_07.R       35       0  100.00%
R/fda-table_08.R       46       0  100.00%
R/fda-table_09.R       34       0  100.00%
R/fda-table_10.R       26       0  100.00%
R/fda-table_11.R       42       0  100.00%
R/fda-table_12.R       40       0  100.00%
R/fda-table_13.R       20       0  100.00%
R/fda-table_14.R       27       0  100.00%
R/fda-table_15.R       32       0  100.00%
R/fda-table_16.R       32       0  100.00%
R/fda-table_17.R       32       0  100.00%
R/fda-table_18.R       32       0  100.00%
R/fda-table_20.R       71       0  100.00%
R/fda-table_21.R       78       0  100.00%
R/fda-table_32.R       71       0  100.00%
R/fda-table_33.R       30       0  100.00%
R/fda-table_34.R       30       0  100.00%
R/utils.R              31       0  100.00%
TOTAL                1103       0  100.00%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  --------
R/fda-table_02.R       -1       0  +100.00%
R/fda-table_04.R       -9       0  +100.00%
R/fda-table_15.R      +32       0  +100.00%
R/fda-table_16.R      +32       0  +100.00%
R/fda-table_17.R      +32       0  +100.00%
R/fda-table_18.R      +32       0  +100.00%
R/fda-table_32.R      +38       0  +100.00%
TOTAL                +156       0  +100.00%

Results for commit: 2d58b5c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@edelarua
Copy link
Collaborator

Please check the R CMD Check warnings and resolve them before merging

@huanlugwu huanlugwu merged commit c69db6f into main Nov 2, 2023
@huanlugwu huanlugwu deleted the 128-new-table-table-15 branch November 2, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edelarua edelarua edelarua approved these changes

Assignees

@edelarua edelarua

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Table]: Table 15, 16, 17 and 18
2 participants
@huanlugwu @edelarua