Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first shot to plugins (and GitHub PR as test case) #268

Merged
merged 13 commits into from
Feb 3, 2017
Merged

first shot to plugins (and GitHub PR as test case) #268

merged 13 commits into from
Feb 3, 2017

Conversation

estebanlm
Copy link
Collaborator

and I do this PR using my thing :)

"separateMethodMetaAndSource" : false,
"useCypressPropertiesFile" : true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be cool if:

  • The exporter could not rewrite metadata without changes
  • The exporter could not change the order of metadata between two export.

I am the only one to be bothered by this?

],
"super" : "BaselineOf",
"type" : "normal" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, the exporter produce a lot of noise for nothing :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files are exported from FileTree right? So If I open an issue it is on FileTree?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty, I opened an issue (dalehenrich/filetree#214)

@@ -0,0 +1,8 @@
private
obtainAvailableBranchNames
^ ((self repository allBranches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is weird, because the same list of branch names is used for both base and head repositories, and there is no warranties that branches might exists in both sides. Isn't it possible to change the set of branches accordingly to the selected repository?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really at that stage (also is not that what github does). What github does is to allow you to put a branch name if you are not convinced with the ones that he offers you.
We can add that later, too

@@ -1,14 +0,0 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why delete this class?

@npasserini npasserini merged commit 4ddee27 into pharo-vcs:dev-0.4 Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants