Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: personal secrets #115

Merged
merged 18 commits into from
Nov 17, 2023
Merged

feat: personal secrets #115

merged 18 commits into from
Nov 17, 2023

Conversation

rohan-chaturvedi
Copy link
Member

@rohan-chaturvedi rohan-chaturvedi commented Nov 14, 2023

Description 📣

Adds the ability to override secrets in an env with personal secrets. Personal secrets will be displayed in the console and be returned by the REST api when a secret is fetched with a PAT

Changes

  • Added PersonalSecret model, types, queries, mutations and schema updates

  • Added 'Override' dialog to SecretRow to allow added a personal secret override to a given secret
    Screenshot from 2023-11-14 17-16-58
    Screenshot from 2023-11-14 17-16-34

  • Added 'override' to REST API response (null if no override)

{
        "id": "0158363d-b976-44e0-9c49-5e77248962e2",
        "override": {
            "id": "ec239b7f-15de-474a-9fb8-0c04d96678e9",
            "value": "ph:v1:dfa94b3f1b1b1af383fee029b98c48779858bc614d917254ee90bd464fbfd24b:RTmt4E4lkhAhQyInUp/poJ0EmIv2CYT7Qw/bTRBRdOEbhQCis+xhADeYThB7qGvG5zSCAin08A==",
            "is_active": true,
            "created_at": "2023-11-14T11:29:39.658523Z",
            "updated_at": "2023-11-14T11:42:40.309809Z",
            "deleted_at": null,
            "secret": "0158363d-b976-44e0-9c49-5e77248962e2",
            "user": "cd3fc3c7-2dbe-41cf-aab2-d8b2fdcee384"
        },
        "key": "ph:v1:e35fd44ae842961daa4874e0340819ebcf7c0d9dd0e8ebf7530257f25894c929:TLJlivQthJIt7GksUMvT7lzJBiW0Tl9tgLx6bPHgQk/HVHveZlkF2HXxh3y248dh6sgPiw==",
        "key_digest": "2fca1b8ea9b28dac2c29ec3b7f269d42b6255c62c6570e9737fa8d52be4fdab2",
        "value": "ph:v1:fd094bcc1085267b9b31e051bb11f8c548dfc7168bd8e03a29b72b8188a6c252:CFq1mi/xK4u/pq5zFic85w77/J3kWowZ7I7uLsjn0qrqThiId31MLFq6QInGG8mgXeJvleMhBZBQpBCbpE8=",
        "version": 28,
        "comment": "ph:v1:e311b74ada739e81d28b3637089d6c7c43848df362e8c54a8940ae0f976bdc21:CnP6LDLyPv8agyd34q8cP5LWGzT2DVdxhEm5zL3WFfTEohe/jpvymkTFauzkTVradjsdKw==",
        "created_at": "2023-08-21T08:38:23.150020Z",
        "updated_at": "2023-10-05T15:46:55.468028Z",
        "deleted_at": null,
        "environment": "fb2775de-6f42-45e6-9986-1a318be43cf7",
        "folder": null,
        "tags": [
            "cdb0d0da-67b7-45dc-816d-5a2d103edbe5",
            "ea27429b-cb10-48ee-96ca-cd9885f08170"
        ]
    }
  • Added smaller action buttons in secret rows for narrower screens:
    Screenshot from 2023-11-14 17-17-39

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

@rohan-chaturvedi rohan-chaturvedi marked this pull request as ready for review November 14, 2023 11:52
@nimish-ks
Copy link
Member

  1. add a feature to make toggling in and out of personal secret overrides without deleting the personal secret simple.
  2. discuss: logs access to personal secrets?
  3. discuss: personal secrets being logged in secret history?

@rohan-chaturvedi
Copy link
Member Author

  1. add a feature to make toggling in and out of personal secret overrides without deleting the personal secret simple.
  2. discuss: logs access to personal secrets?
  3. discuss: personal secrets being logged in secret history?

Re. point 2&3: no, personal secrets are not logged or shown in history.

@rohan-chaturvedi rohan-chaturvedi merged commit 26b92d6 into main Nov 17, 2023
6 checks passed
@rohan-chaturvedi rohan-chaturvedi deleted the feat--personal-secrets branch November 17, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants