-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: service accounts #383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: added sidebar state local storage context util * feat: collapsible sidebar * feat: sidebar provider in providers * fix: misc updates to smooth transitions between states * feat: misc tweaks to orgs menu * fix: load stored state after component mount to prevent hydration mismatch --------- Co-authored-by: Rohan <[email protected]>
nimish-ks
previously approved these changes
Nov 21, 2024
* feat: consolidate seat quota logic * feat: misc updates to plan info display * refactor: org seat usage types * fix: misc copy and ui updates * feat: remove feature list on self-hosted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Overview
Currently, programmatic access to secrets in Phase can be achieved primarily via Service Tokens. These have significant limitations:
💡 Proposed Changes
Add service accounts to allow for more sophisticated workflows around programmatic secret management. Service accounts are the machine equivalent of human users, and operate in much the same way:
Secrets:read
permission)Service accounts also lays the foundation for more sophisticated authentication and access control, including third-party auth, path-based access, IP-base access and other features that we will be shipping in the near future
🖼️ Screenshots or Demo
📝 Release Notes
Added Service accounts
💚 Did You...