Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: truncate text in navbar #384

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

nimish-ks
Copy link
Member

🔍 Overview

Long application names, environment names, and other elements in the navigation bar currently overflow their containers, leading to layout issues. This affects the UI's cleanliness and usability, particularly with longer text strings.

💡 Proposed Changes

  • Added CSS-based text truncation for navigation elements that can overflow
  • Implemented flexible width handling while maintaining the navbar's existing structure
  • Added shrink-0 to fixed elements (logo, separators) to preserve their dimensions
  • Applied text-ellipsis to truncatable elements while allowing them to expand when space permits

🖼️ Screenshots or Demo

Before:
image

After:
image

📝 Release Notes

  • Fixed UI issue where long application names and environment names would overflow in the navigation bar
  • Improved responsive behavior of navigation text elements

🧪 Testing

Test cases to verify:

  • Very long application names (>30 characters)
  • Multiple environment names in the path
  • Different viewport widths
  • Various browser zoom levels

🎯 Reviewer Focus

  • Check NavBar.tsx for the CSS class changes
  • Verify truncation behavior at different screen sizes
  • Ensure the navbar maintains its layout structure

💚 Did You...

  • Verify the app builds locally
  • Manually test the changes on different browsers/devices
  • Test with various text lengths and viewport sizes

This is a purely CSS-based fix with no functional changes to the application's behavior.

@nimish-ks nimish-ks added bug Something isn't working enhancement New feature or request frontend Change in frontend code typescript Pull requests that update Typescript code labels Oct 28, 2024
@nimish-ks nimish-ks self-assigned this Oct 28, 2024
@nimish-ks nimish-ks merged commit 2fedcd8 into main Oct 28, 2024
6 checks passed
@nimish-ks nimish-ks deleted the feat--navbar--ui-improvements branch October 28, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request frontend Change in frontend code typescript Pull requests that update Typescript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants