Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: permission checks and rendering for onboarding guide #391

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

rohan-chaturvedi
Copy link
Member

🔍 Overview

The "Getting Started" guide does not update to reflect the current state of the completed steps, due to an incorrect permission check that caused the query to be skipped

💡 Proposed Changes

  • Fix the permission check to allow the required query to be executed and render the correct state of the guide
  • Defer rendering the guide if the required permissions are not available, rather than show the guide with incorrect state

🖼️ Screenshots or Demo

image

📝 Release Notes

Fixed a bug that caused the "Getting started" guide on the organisation home page to not update correctly.

💚 Did You...

  • Ensure linting passes (code style checks)?
    - [ ] Update dependencies and lockfiles (if required)
    - [ ] Regenerate graphql schema and types (if required)
  • Verify the app builds locally?
  • Manually test the changes on different browsers/devices?

@nimish-ks nimish-ks merged commit f8846e3 into main Nov 19, 2024
6 checks passed
@nimish-ks nimish-ks deleted the fix--onboarding-guide branch November 19, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants