Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: client-side exception during signup due to nested toast container #409

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

rohan-chaturvedi
Copy link
Member

🔍 Overview

There are currently 2 <ToastContainer/>s for react-toastify. One at the root layout, and one within the [team] layout which is theme-aware. This causes a client-side exception when a toast originating in the root layout container is still active, and the route changes to [team]/*. This was most commonly experienced during signup, when redirecting to the org home page.

💡 Proposed Changes

Remove the nested toast container in the team layout.

📝 Release Notes

Fixed a bug during signup that cause a client-side exception.

🎯 Reviewer Focus

Run through the signup process. Observe that the toast drawn on signup remains active once redirected to org home, and no client-side exception occurs

➕ Additional Context

This change makes toasts 'dark' theme regardless of the console theme selection. We will revisit this in the future.

💚 Did You...

  • Ensure linting passes (code style checks)?
    - [ ] Update dependencies and lockfiles (if required)
    - [ ] Regenerate graphql schema and types (if required)
  • Verify the app builds locally?
  • Manually test the changes on different browsers/devices?

@nimish-ks nimish-ks merged commit 98e89a1 into main Dec 9, 2024
6 checks passed
@nimish-ks nimish-ks deleted the fix--react-toastify-error branch December 9, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants