fix: client-side exception during signup due to nested toast container #409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Overview
There are currently 2
<ToastContainer/>
s for react-toastify. One at the root layout, and one within the[team]
layout which is theme-aware. This causes a client-side exception when a toast originating in the root layout container is still active, and the route changes to[team]/*
. This was most commonly experienced during signup, when redirecting to the org home page.💡 Proposed Changes
Remove the nested toast container in the team layout.
📝 Release Notes
Fixed a bug during signup that cause a client-side exception.
🎯 Reviewer Focus
Run through the signup process. Observe that the toast drawn on signup remains active once redirected to org home, and no client-side exception occurs
➕ Additional Context
This change makes toasts 'dark' theme regardless of the console theme selection. We will revisit this in the future.
💚 Did You...
- [ ] Update dependencies and lockfiles (if required)- [ ] Regenerate graphql schema and types (if required)