Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gracefully handle DoesNotExist exceptions for tokens #413

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

rohan-chaturvedi
Copy link
Member

@rohan-chaturvedi rohan-chaturvedi commented Dec 11, 2024

🔍 Overview

When the REST api is accessed with a deleted token, it incorrectly errors out with a status 500 code. This due to the token's DoesNotExist exception not being handled correctly during the intial token validation check

💡 Proposed Changes

Gracefully hande DoesNotExist errors and return status 403 response

📝 Release Notes

Fix a bug with REST api authentication when using deleted tokens

💚 Did You...

  • Ensure linting passes (code style checks)?
    - [ ] Update dependencies and lockfiles (if required)
    - [ ] Regenerate graphql schema and types (if required)
  • Verify the app builds locally?
  • Manually test the changes on different browsers/devices?

@nimish-ks nimish-ks merged commit 391e4a5 into main Dec 11, 2024
6 checks passed
@nimish-ks nimish-ks deleted the fix--rest-handle-deleted-tokens branch December 11, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants