Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: seat count calculation in plan detail resolver #418

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

rohan-chaturvedi
Copy link
Member

@rohan-chaturvedi rohan-chaturvedi commented Dec 17, 2024

🔍 Overview

The seat counts for users and service accounts is incorrectly displayed in certain situations.

💡 Proposed Changes

Fix the seat count calculations in the OrganisationPlan resolver

📝 Release Notes

Fixed a bug that caused incorrect seat counts to be displayed on various screens in the Console

🎯 Reviewer Focus

Verify that the seat counts in the Settings > Usage section are correct

Screenshot From 2024-12-17 14-11-10

Verify that the seat counts in the self checkout screen are correct

image

💚 Did You...

  • Ensure linting passes (code style checks)?
    - [ ] Update dependencies and lockfiles (if required)
    - [ ] Regenerate graphql schema and types (if required)
  • Verify the app builds locally?
  • Manually test the changes on different browsers/devices?

@nimish-ks nimish-ks merged commit d0d8808 into main Dec 17, 2024
6 checks passed
@nimish-ks nimish-ks deleted the fix--seat-count-calculation branch December 17, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants