Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: misc fixes for creating new apps, keyring and example secrets #86

Merged
merged 3 commits into from
Oct 17, 2023
Merged

refactor: misc fixes for creating new apps, keyring and example secrets #86

merged 3 commits into from
Oct 17, 2023

Conversation

rohan-chaturvedi
Copy link
Member

@rohan-chaturvedi rohan-chaturvedi commented Oct 16, 2023 •
edited
Loading

Description 📣

Fixes multiple issues when creating an app.

  • Fixes envs not being correctly queried after creating an app
  • Fixed an issue when creating a new app with example secrets, and the user keyring isn't unlocked.
  • Patched the graphql EnvironmentType to correctly return the wrappedSeed and wrappedSalt specific to the querying user
  • Refactor to fix misc other async related issues around initializing envs for new apps, and creation of example secrets.

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

@rohan-chaturvedi rohan-chaturvedi changed the title fix: ensure keyring is unlocked when creating example secrets refactor: misc fixes for creating new apps, keyring and example secrets Oct 17, 2023
@nimish-ks nimish-ks merged commit 575f07a into main Oct 17, 2023
6 checks passed
@nimish-ks nimish-ks deleted the fix--example-secrets-keyring branch October 17, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimish-ks nimish-ks nimish-ks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohan-chaturvedi @nimish-ks