Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper autoloading for composer, PSR-4 compliant, Cleanup #138

Closed
wants to merge 6 commits into from

Conversation

jmleroux
Copy link

@jmleroux jmleroux commented Feb 8, 2017

Fix #130 for tests.

@jmleroux jmleroux force-pushed the fix-PR-130 branch 4 times, most recently from 317be82 to cb029dc Compare February 8, 2017 22:34
* remove PHP 5.3 because of namespaces
* add PHP 7.0 and 7.1
* remove xdebug
* use phpunit from vendor and remove useless bootstrap file
@jmleroux
Copy link
Author

jmleroux commented Feb 8, 2017

Hello,
Is this repo still active or should i switch to some fork ?

@mishal
Copy link
Contributor

mishal commented Feb 9, 2017

The author is not active anymore in this repo.

There are several branches which try to fix the autoloading and namespaces collisions (including mine).

@jmleroux
Copy link
Author

jmleroux commented Feb 9, 2017

Thx for your answer, i'll switch to your repo.
You could maybe ask the ownership transfer, or some admin rights on this repo. This would be better for the future of this library.

@BathoryPeter
Copy link

Or you can try my fork: funiq/geoPHP
For a detailed description about improvements look at this commit.

@jmleroux
Copy link
Author

jmleroux commented Feb 9, 2017

Thanks Peter for this contribution. Very interresting.
It's just sad there is so many forks when people could have worked together... 😐
You guys are doing a good job and it would be so much better if you could join forces.

For the record, i think i will choose mishal fork. Not because i think it is better or not, but it is more up to date with the original repo.

@mishal
Copy link
Contributor

mishal commented Feb 9, 2017

what to say.. you are absolutely right...

I tried to contact the original author in the past (If any PRs will be merged and are worth preparing), but with no success.

@teiling88 teiling88 mentioned this pull request May 15, 2017
@jmleroux
Copy link
Author

I'm feeling like i should close this PR. There are already many with the same concern.
And BTW, i also feel like i should switch to a maintained fork. 😞

@jmleroux jmleroux closed this May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants