Fix broken link in contributing document #4565
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleSnail
approved these changes
Oct 29, 2024
|
Yeah no worries! Just wanted to float a possibility of a more systematic prevention for this, but I presume this is low prio. Anyhow, feel free to merge the PR if you can, I don't seem to have the rights. |
No, only maintainers with write access can merge. It just can speed up the process sometimes if I have already reviewed the PRs before they get to them so that if there are obvious issues, they can be fixed before a maintainer views it. The maintainers have a lot to do, so it could be a long time between reviews. If they can merge/reject in one review rather than 2, or even just see that another contributor thinks the changes are sane, it's easier for everyone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current link doesn't lead to the desired page:
This PR fixes it.
A more systematic fix might be to use some kind of a broken link finder, perhaps in a cron-triggered GitHub workflow (e.g. this — note that I haven't tried this one).