Drop Django 3.2, Add Django 5.0, use Ruff for linting and formatting #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruff pre-commit hook omitted so that we can commit this before fixing everything
Former is only from python 3.11 onwards
Mostly as a result of me doing stuff that Ruff said, but doing it wrongly. A few instances of datetimes, now with timezones, that were out, but which I *think* are now correct. And a few instances where a templatetag was being called with an arg instead of a kwarg
Partly as a result of django-taggit 5.0 doing the same, and us doing the same being simpler, and it coming out of LTS soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Removed
Changed
Fixes #243