chore: resolved sonar warnings

philips-software · Jan 24, 2024 · 0ee2574 · 0ee2574
1 parent c351cfc
commit 0ee2574
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/cucumber-cpp/FeatureRunner.cpp b/cucumber-cpp/FeatureRunner.cpp
@@ -30,7 +30,14 @@ namespace cucumber_cpp
 
     FeatureRunnerV2::~FeatureRunnerV2()
     {
-        stopFeatureOnDestruction();
+        try
+        {
+            stopFeatureOnDestruction();
+        }
+        catch (...)
+        {
+            std::cout << "\nexception caught during FeatureRunner dtor";
+        }
     }
 
     const FeatureSource& FeatureRunnerV2::Source() const

diff --git a/cucumber-cpp/TagsToSet.hpp b/cucumber-cpp/TagsToSet.hpp
@@ -10,8 +10,7 @@ namespace cucumber_cpp
 {
     std::set<std::string, std::less<>> TagsToSet(const auto& tags)
     {
-        decltype(TagsToSet(tags)) result;
-        // std::set<std::string, std::less<>> result;
+        std::set<std::string, std::less<>> result;
 
         for (const auto& entry : tags)
             result.insert(entry.name);