fix: in HttpClientApplication don't crash when detaching during Statu…

…sAvailable (#770)
philips-software · Nov 12, 2024 · e626133 · e626133
1 parent ea7de38
commit e626133
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/services/network/HttpClientAuthentication.cpp b/services/network/HttpClientAuthentication.cpp
@@ -155,7 +155,8 @@ namespace services
             Observer().StatusAvailable(HttpStatusCode::Unauthorized);
         }
 
-        Observer().BodyComplete();
+        if (HttpClient::IsAttached())
+            Observer().BodyComplete();
     }
 
     void HttpClientAuthentication::SendStreamAvailable(infra::SharedPtr<infra::StreamWriter>&& writer)
@@ -170,7 +171,8 @@ namespace services
 
     void HttpClientAuthentication::Detaching()
     {
-        HttpClient::Detach();
+        if (HttpClient::IsAttached())
+            HttpClient::Detach();
         HttpClientObserver::Detaching();
     }
 

diff --git a/services/network/test/TestHttpClientAuthentication.cpp b/services/network/test/TestHttpClientAuthentication.cpp
@@ -37,7 +37,8 @@ class HttpClientAuthenticationTest
 
     ~HttpClientAuthenticationTest() override
     {
-        EXPECT_CALL(*httpClientObserver, Detaching());
+        if (httpClientObserver->IsAttached())
+            EXPECT_CALL(*httpClientObserver, Detaching());
     }
 
     void CheckHeaders(services::HttpHeaders headersToCheck, infra::BoundedConstString headerValueToAdd)
@@ -261,3 +262,27 @@ TEST_F(HttpClientAuthenticationTest, unauthorized_is_retried)
         }));
     httpClient.Observer().BodyComplete();
 }
+
+TEST_F(HttpClientAuthenticationTest, detach_during_StatusAvailable)
+{
+    Get();
+
+    httpClient.Observer().StatusAvailable(services::HttpStatusCode::Unauthorized);
+
+    httpClient.Observer().HeaderAvailable({ "name", "value" });
+    EXPECT_CALL(clientAuthentication, AuthenticationHeader()).WillOnce(testing::Return("header contents"));
+    EXPECT_CALL(clientAuthentication, Authenticate(services::HttpVerb::get, "target", "scheme", "value"));
+    httpClient.Observer().HeaderAvailable({ "WWW-Authenticate", "scheme value" });
+
+    testing::StrictMock<infra::StreamReaderMock> reader;
+    EXPECT_CALL(reader, Empty()).WillOnce(testing::Return(true));
+    httpClient.Observer().BodyAvailable(infra::UnOwnedSharedPtr(reader));
+
+    EXPECT_CALL(clientAuthentication, Retry()).WillOnce(testing::Return(false));
+    EXPECT_CALL(*httpClientObserver, StatusAvailable(services::HttpStatusCode::Unauthorized)).WillOnce(testing::Invoke([this](services::HttpStatusCode)
+        {
+            EXPECT_CALL(*httpClientObserver, Detaching());
+            httpClientObserver->Detach();
+        }));
+    httpClient.Observer().BodyComplete();
+}