feat: enable SHA384 and SHA512 on mbedtls #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardapeters
approved these changes
Oct 23, 2024
BartKerkhoff
changed the title
richardapeters
changed the title
Merged
via the queue into
philips-software:main
with commit Oct 23, 2024
2c0351e
26 of 30 checks passed
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next to the already supported SHA256 algorithm, it is also common to sign certificates based on SHA384 and SHA512. These algorithms were not yet enabled. As a result, certificate validation would fail when any of the certificates in the chain was signed based on one of these hash algorithms.
Enabling these algorithms as I am running into these issues right now. Since we are only enabling new features, this change is not expected to break existing functionality.