Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fluxomics stationary #14

Merged
merged 3 commits into from
Feb 28, 2017
Merged

Conversation

pcm32
Copy link
Member

@pcm32 pcm32 commented Feb 27, 2017

This PR adds the fluxomics stationary workflow test, previously checked to work without issues.

I'm under the increased impression that we shouldn't really put our test definitions here but on separate repos, but I will ask to merge my working example for the fluxomics stationary pipeline here in the meantime.

@kikkomep kikkomep merged commit eb84b75 into develop Feb 28, 2017
@pcm32
Copy link
Member Author

pcm32 commented Feb 28, 2017

Thanks @kikkomep!

@ilveroluca
Copy link
Member

Yes @pcm32 , I agree with what you say regarding putting test definitions elsewhere. We had briefly chatted about it in #galaxy-related. I had proposed putting each of our supported workflows in its own repository, along with any tests. I would suggest a layout that looks something like this:

workflow.ga
tests/
    test_1/
        test_definition.yml
        input/
        expected/
     test_2/
        ....

We would then add these tests to Jenkins and somehow integrate then into our system deployment procedure.

@pcm32
Copy link
Member Author

pcm32 commented Feb 28, 2017

Mind reading #15 ;-)

@ilveroluca ilveroluca deleted the feature/fluxomics_stationary branch June 6, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants