Apply suggestions from code review

parse curly braces directive only with single expressions Co-authored-by: Jonatan Kłosko <[email protected]>
phoenixframework · Dec 9, 2024 · a5075e6 · a5075e6
1 parent cd47553
commit a5075e6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/grammar.js b/grammar.js
@@ -131,19 +131,7 @@ module.exports = grammar({
             )
           )
         ),
-        seq(
-          choice("{"),
-          prec.left(
-            seq(
-              choice(
-                $.partial_expression_value,
-                $.ending_expression_value,
-                $.expression_value
-              ),
-              choice("}")
-            )
-          )
-        )
+        alias($.expression, "expression")
       ),
 
     comment: ($) => choice($._html_comment, $._bang_comment, $._hash_comment),

diff --git a/test/corpus/directives.txt b/test/corpus/directives.txt
@@ -47,7 +47,10 @@ Curly braces as directive
 
 <div>
   { @message }
+  {@message}
+  {"#{1}"}
 </div>
+
 --------------------------------------------------------------------------------
 
 (fragment
@@ -56,5 +59,9 @@ Curly braces as directive
       (tag_name))
     (directive
       (expression_value))
+    (directive
+      (expression_value))
+    (directive
+      (expression_value))
     (end_tag
       (tag_name))))