-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix in RdKafkaProducer:flush()
method
#1347
base: master
Are you sure you want to change the base?
Conversation
Avoid TypeError in `RdKafkaProducer::flush()`
It seems there is an issue with localstack deployment, because after the services are up, one of them (the one on port 4576) shuts down. All of the http requests to service healtcheck |
@makasim ok, please let me know - since this is a failing component of testing stage (not related to the code quality/functionality itself) - who could help me with this issue? I mean, who is maintaining the functional tests environment, so we can check together? |
Contributors, like you. |
@makasim please run the workflow. I've brought some changes. |
@makasim please run the workflow again. |
@makasim please run the workflow. |
Now the only failing test is
@makasim @Steveb-p it's not clear to me why this fails here; it is not failing when I run for the same environment on my local machine. What would you suggest, what should I try? |
a6fb467
to
aa29e73
Compare
9d9a04f
to
12d3738
Compare
Avoid TypeError in
RdKafkaProducer::flush()