[gearman] fix tests.

php-enqueue · Jun 27, 2017 · 27ee35e · 27ee35e
1 parent c74f774
commit 27ee35e
Show file tree

Hide file tree

Showing 10 changed files with 39 additions and 30 deletions.
diff --git a/Tests/GearmanConnectionFactoryConfigTest.php b/Tests/GearmanConnectionFactoryConfigTest.php
@@ -8,12 +8,11 @@
 
 /**
  * The class contains the factory tests dedicated to configuration.
- *
- * @group functional
  */
 class GearmanConnectionFactoryConfigTest extends TestCase
 {
     use ClassExtensionTrait;
+    use SkipIfGearmanExtensionIsNotInstalledTrait;
 
     public function testThrowNeitherArrayStringNorNullGivenAsConfig()
     {
@@ -57,24 +56,24 @@ public static function provideConfigs()
         yield [
             null,
             [
-                'host' => \GEARMAN_DEFAULT_TCP_HOST,
-                'port' => \GEARMAN_DEFAULT_TCP_PORT,
+                'host' => 'localhost',
+                'port' => 4730,
             ],
         ];
 
         yield [
             'gearman://',
             [
-                'host' => \GEARMAN_DEFAULT_TCP_HOST,
-                'port' => \GEARMAN_DEFAULT_TCP_PORT,
+                'host' => 'localhost',
+                'port' => 4730,
             ],
         ];
 
         yield [
             [],
             [
-                'host' => \GEARMAN_DEFAULT_TCP_HOST,
-                'port' => \GEARMAN_DEFAULT_TCP_PORT,
+                'host' => 'localhost',
+                'port' => 4730,
             ],
         ];
 
@@ -98,7 +97,7 @@ public static function provideConfigs()
             ['host' => 'theHost'],
             [
                 'host' => 'theHost',
-                'port' => \GEARMAN_DEFAULT_TCP_PORT,
+                'port' => 4730,
             ],
         ];
     }

diff --git a/Tests/GearmanContextTest.php b/Tests/GearmanContextTest.php
@@ -15,6 +15,7 @@
 class GearmanContextTest extends TestCase
 {
     use ClassExtensionTrait;
+    use SkipIfGearmanExtensionIsNotInstalledTrait;
 
     public function testShouldImplementPsrContextInterface()
     {

diff --git a/Tests/GearmanDestinationTest.php b/Tests/GearmanDestinationTest.php
@@ -8,12 +8,10 @@
 use Enqueue\Test\ClassExtensionTrait;
 use PHPUnit\Framework\TestCase;
 
-/**
- * @group functional
- */
 class GearmanDestinationTest extends TestCase
 {
     use ClassExtensionTrait;
+    use SkipIfGearmanExtensionIsNotInstalledTrait;
 
     public function testShouldImplementPsrQueueInterface()
     {

diff --git a/Tests/GearmanMessageTest.php b/Tests/GearmanMessageTest.php
@@ -6,12 +6,10 @@
 use Enqueue\Test\ClassExtensionTrait;
 use PHPUnit\Framework\TestCase;
 
-/**
- * @group functional
- */
 class GearmanMessageTest extends TestCase
 {
     use ClassExtensionTrait;
+    use SkipIfGearmanExtensionIsNotInstalledTrait;
 
     public function testShouldAllowGetJobPreviouslySet()
     {

diff --git a/Tests/GearmanProducerTest.php b/Tests/GearmanProducerTest.php
@@ -12,12 +12,10 @@
 use Enqueue\Test\ClassExtensionTrait;
 use PHPUnit\Framework\TestCase;
 
-/**
- * @group functional
- */
 class GearmanProducerTest extends TestCase
 {
     use ClassExtensionTrait;
+    use SkipIfGearmanExtensionIsNotInstalledTrait;
 
     public function testCouldBeConstructedWithGearmanClientAsFirstArgument()
     {

diff --git a/Tests/SkipIfGearmanExtensionIsNotInstalledTrait.php b/Tests/SkipIfGearmanExtensionIsNotInstalledTrait.php
@@ -0,0 +1,15 @@
+<?php
+
+namespace Enqueue\Gearman\Tests;
+
+trait SkipIfGearmanExtensionIsNotInstalledTrait
+{
+    public function setUp()
+    {
+        if (false == class_exists(\GearmanClient::class)) {
+            $this->markTestSkipped('The gearman extension is not installed');
+        }
+
+        parent::setUp();
+    }
+}
diff --git a/Tests/Spec/GearmanConnectionFactoryTest.php b/Tests/Spec/GearmanConnectionFactoryTest.php
@@ -3,13 +3,13 @@
 namespace Enqueue\Gearman\Tests\Spec;
 
 use Enqueue\Gearman\GearmanConnectionFactory;
+use Enqueue\Gearman\Tests\SkipIfGearmanExtensionIsNotInstalledTrait;
 use Enqueue\Psr\Spec\PsrConnectionFactorySpec;
 
-/**
- * @group functional
- */
 class GearmanConnectionFactoryTest extends PsrConnectionFactorySpec
 {
+    use SkipIfGearmanExtensionIsNotInstalledTrait;
+
     /**
      * {@inheritdoc}
      */

diff --git a/Tests/Spec/GearmanMessageTest.php b/Tests/Spec/GearmanMessageTest.php
@@ -3,13 +3,13 @@
 namespace Enqueue\Gearman\Tests\Spec;
 
 use Enqueue\Gearman\GearmanMessage;
+use Enqueue\Gearman\Tests\SkipIfGearmanExtensionIsNotInstalledTrait;
 use Enqueue\Psr\Spec\PsrMessageSpec;
 
-/**
- * @group functional
- */
 class GearmanMessageTest extends PsrMessageSpec
 {
+    use SkipIfGearmanExtensionIsNotInstalledTrait;
+
     /**
      * {@inheritdoc}
      */

diff --git a/Tests/Spec/GearmanQueueTest.php b/Tests/Spec/GearmanQueueTest.php
@@ -3,13 +3,13 @@
 namespace Enqueue\Gearman\Tests\Spec;
 
 use Enqueue\Gearman\GearmanDestination;
+use Enqueue\Gearman\Tests\SkipIfGearmanExtensionIsNotInstalledTrait;
 use Enqueue\Psr\Spec\PsrQueueSpec;
 
-/**
- * @group functional
- */
 class GearmanQueueTest extends PsrQueueSpec
 {
+    use SkipIfGearmanExtensionIsNotInstalledTrait;
+
     /**
      * {@inheritdoc}
      */

diff --git a/Tests/Spec/GearmanTopicTest.php b/Tests/Spec/GearmanTopicTest.php
@@ -3,13 +3,13 @@
 namespace Enqueue\Gearman\Tests\Spec;
 
 use Enqueue\Gearman\GearmanDestination;
+use Enqueue\Gearman\Tests\SkipIfGearmanExtensionIsNotInstalledTrait;
 use Enqueue\Psr\Spec\PsrTopicSpec;
 
-/**
- * @group functional
- */
 class GearmanTopicTest extends PsrTopicSpec
 {
+    use SkipIfGearmanExtensionIsNotInstalledTrait;
+
     /**
      * {@inheritdoc}
      */