Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "command defined in ....\SetupBrokerCommand" cannot have an empty name and configure() must be compatible with Enqueue\Symfony\Client\SetupBrokerCommand::configure(): void #32

Merged
merged 5 commits into from
Apr 4, 2025

Conversation

xseguib
Copy link
Contributor

@xseguib xseguib commented Apr 4, 2025

Hey, its me again.

I created this PR in order to fix all Laravel Commands not inheriting the Symfony Attribute AsCommand.

I also rollbacked the last PR as it was causing another error.

Both things are fixed in this PR

Thanks!

@makasim makasim merged commit 59e55b6 into php-enqueue:master Apr 4, 2025
@mhv666
Copy link
Contributor

mhv666 commented Apr 7, 2025

Hi guys, sorry to bother again, how can we release a new tag for that fix ?

@makasim
Copy link
Member

makasim commented Apr 7, 2025

works?

@mhv666
Copy link
Contributor

mhv666 commented Apr 7, 2025

I think so, at least is not showing the error again. Thanks 🙇🏽

@makasim
Copy link
Member

makasim commented Apr 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants