Apply suggestions from code review

php-etl · Jun 23, 2023 · 7f79a66 · 7f79a66
1 parent 35933a4
commit 7f79a66
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/WithSimpleOption.php b/src/WithSimpleOption.php
@@ -38,7 +38,7 @@ private function compile(string $code, string $attribute, string $labels, string
     /**
      * @return array<int, array<string, array<string, array|string>|string|null>>
      */
-    private function evaluate(array $context, string $code, string $attribute, array $labels, string|null $locale = null, string|null $scope = null): array
+    private function evaluate(array $context, string $code, string $attribute, array $labels, string $locale = 'null', string $scope = 'null'): array
     {
         return [[
             'locale' => $locale,

diff --git a/src/WithValue.php b/src/WithValue.php
@@ -22,7 +22,7 @@ private function compile(string $value, string $locale = 'null', string $scope =
         return sprintf('([["data" => (%s), "locale" => (%s), "scope" => (%s)]])', $value, $locale, $scope);
     }
 
-    private function evaluate(array $context, string $value, string|null $locale = null, string|null $scope = null): array
+    private function evaluate(array $context, string $value, string $locale = 'null', string $scope = 'null'): array
     {
         return [[
             'locale' => $locale,