Fix client api version to 2.4

php-etl · Jan 31, 2024 · ef45ba6 · ef45ba6
1 parent b9ba56b
commit ef45ba6
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 26 deletions.
diff --git a/.github/workflows/phpstan-9.yaml b/.github/workflows/phpstan-9.yaml
@@ -1,4 +1,4 @@
-name: PHPStan level 8
+name: PHPStan level 9
 on: push
 jobs:
   phpstan-9:

diff --git a/composer.json b/composer.json
@@ -22,7 +22,7 @@
         "psr/log": "^3.0",
         "nyholm/psr7": "^1.5",
         "php-etl/bucket": "*",
-        "php-etl/magento2-api-client": "^0.1.0",
+        "php-etl/magento2-api-client": "2.4.x-dev",
         "psr/simple-cache": "^3.0",
         "php-etl/mapping-contracts": "0.4.*"
     },

diff --git a/composer.lock b/composer.lock
diff --git a/src/CustomerExtractor.php b/src/CustomerExtractor.php
@@ -7,7 +7,6 @@
 use Kiboko\Component\Bucket\AcceptanceResultBucket;
 use Kiboko\Component\Bucket\RejectionResultBucket;
 use Kiboko\Contract\Bucket\RejectionResultBucketInterface;
-use Kiboko\Contract\Bucket\ResultBucketInterface;
 use Kiboko\Contract\Pipeline\ExtractorInterface;
 use Kiboko\Magento\Client;
 use Kiboko\Magento\Exception\GetV1CustomersSearchInternalServerErrorException;

diff --git a/src/FilterGroup.php b/src/FilterGroup.php
@@ -19,11 +19,9 @@ public function withFilter(FilterInterface $filter): self
         return $this;
     }
 
-    public function withFilters(FilterInterface ...$filter): self
+    public function withFilters(FilterInterface ...$filters): self
     {
-        foreach ($filter as $item) {
-            $this->filters[] = $item;
-        }
+        array_push($this->filters, ...$filters);
 
         return $this;
     }

diff --git a/src/QueryParameters.php b/src/QueryParameters.php
@@ -16,11 +16,9 @@ public function withGroup(FilterGroup $group): self
         return $this;
     }
 
-    public function withGroups(FilterGroup ...$group): self
+    public function withGroups(FilterGroup ...$groups): self
     {
-        foreach ($group as $item) {
-            $this->groups[] = $item;
-        }
+        array_push($this->groups, ...$groups);
 
         return $this;
     }