Fixed PHPStan issues, upgraded to level 5

php-etl · Nov 13, 2023 · b9264b8 · b9264b8
1 parent 83934dc
commit b9264b8
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 28 deletions.
diff --git a/.github/workflows/phpstan-5.yaml b/.github/workflows/phpstan-5.yaml
diff --git a/.github/workflows/quality.yaml b/.github/workflows/quality.yaml
@@ -34,5 +34,5 @@ jobs:
         uses: php-actions/phpstan@v3
         with:
           path: src/
-          level: 4
+          level: 5
           php_version: '8.2'
diff --git a/src/NullRejection.php b/src/NullRejection.php
@@ -11,12 +11,13 @@ public function initialize(): void
         // NOOP
     }
 
-    /** @param non-empty-array<mixed>|object $rejection */
+    /** @param non-empty-array<array-key, mixed>|object $rejection */
     public function reject(StepCodeInterface $step, array|object $rejection, \Throwable $exception = null, string $reason = null): void
     {
         // NOOP
     }
 
+    /** @param non-empty-array<array-key, mixed>|object $rejection */
     public function rejectWithReason(StepCodeInterface $step, object|array $rejection, string $reason, \Throwable $exception = null): void
     {
         // NOOP

diff --git a/src/PipelineRunnerInterface.php b/src/PipelineRunnerInterface.php
@@ -12,7 +12,7 @@
 interface PipelineRunnerInterface
 {
     /**
-     * @param \Iterator<array|object>                                    $source
+     * @param \Iterator<int, array|object> $source
      * @param \Generator<mixed, Type, ResultBucketInterface<Type>, void> $async
      *
      * @return \Iterator<array|object>

diff --git a/src/RejectionInterface.php b/src/RejectionInterface.php
@@ -8,9 +8,10 @@ interface RejectionInterface
 {
     public function initialize(): void;
 
-    /** @param non-empty-array<mixed>|object $rejection */
+    /** @param non-empty-array<array-key, mixed>|object $rejection */
     public function reject(StepCodeInterface $step, array|object $rejection, \Throwable $exception = null): void;
 
+    /** @param non-empty-array<array-key, mixed>|object $rejection */
     public function rejectWithReason(StepCodeInterface $step, array|object $rejection, string $reason, \Throwable $exception = null): void;
 
     public function teardown(): void;