Fixed condition to avoid a fatal error

php-etl · Oct 31, 2023 · 1f751d1 · 1f751d1
1 parent b06361e
commit 1f751d1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Plugin/Filtering/Builder/ExclusionsBuilder.php b/src/Plugin/Filtering/Builder/ExclusionsBuilder.php
@@ -9,7 +9,7 @@
 use PhpParser\Builder;
 use PhpParser\Node;
 
-final class ExclusionsBuilder extends Builder
+final class ExclusionsBuilder implements Builder
 {
     /** @var list<list<Node\Expr>> */
     private array $exclusions = [];
@@ -24,7 +24,7 @@ public function withCondition(Node\Expr $condition, ?Node\Expr $reason = null):s
         return $this;
     }
 
-    public function getNode(): array
+    public function getNode(): Node
     {
         $statements = [];
         foreach ($this->exclusions as $exclusion) {
@@ -56,6 +56,6 @@ public function getNode(): array
             );
         }
 
-        return $statements;
+        return new Node;
     }
 }
diff --git a/src/Plugin/Filtering/Factory/Reject.php b/src/Plugin/Filtering/Factory/Reject.php
@@ -73,7 +73,7 @@ public function compile(array $config): Repository\Reject
             $exclusionBuilder
                 ->withCondition(
                     compileExpression($interpreter, $condition['when']),
-                    compileValueWhenExpression($interpreter, $condition['reason']) ?: null,
+                    \array_key_exists('reason', $condition) ? compileValueWhenExpression($interpreter, $condition['reason']) : null,
                 );
         }
         $builder->withExclusions($exclusionBuilder);