Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reason option into the configuration #115

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

sebprt
Copy link
Contributor

@sebprt sebprt commented Jul 28, 2023

No description provided.

@sebprt sebprt added the WIP label Jul 28, 2023
@sebprt sebprt self-assigned this Jul 28, 2023
@sebprt sebprt force-pushed the feature/reject-with-reason branch from 56a38e9 to 59de5a4 Compare October 20, 2023 07:29
Copy link
Contributor

@JoMessina JoMessina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je valide, mais il faudra rebase la branche avec le serialize_rejection

return $this;
}

public function getNode(): array
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il me semble que getNode() doive renvoyer un objet PhpParser\Node

@sebprt sebprt force-pushed the feature/reject-with-reason branch from 1f751d1 to 354388c Compare June 25, 2024 08:05
@sebprt sebprt force-pushed the feature/reject-with-reason branch from b2bab02 to ff51a50 Compare June 25, 2024 12:05
@sebprt sebprt requested a review from gplanchat June 25, 2024 15:13
@sebprt sebprt added GTM and removed WIP labels Jun 25, 2024
@sebprt sebprt linked an issue Jun 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

[REJECTION] Reason
3 participants