Added PHPStan rule to ignore while(true) statement

php-etl · Nov 22, 2023 · c105457 · c105457
1 parent 192f6b6
commit c105457
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/src/CSV/FingersCrossed/Loader.php b/src/CSV/FingersCrossed/Loader.php
@@ -27,7 +27,7 @@ public function __construct(
 
     public function load(): \Generator
     {
-        $line = yield;
+        $line = yield new EmptyResultBucket();
         try {
             $this->writer->addRow(
                 new Row(array_map(fn ($value) => new Cell($value), array_keys($line)), null)
@@ -41,6 +41,7 @@ public function load(): \Generator
             );
         }
 
+        /* @phpstan-ignore-next-line */
         while (true) {
             try {
                 $this->writer->addRow(
@@ -53,6 +54,7 @@ public function load(): \Generator
                     $exception,
                     $line
                 );
+                continue;
             }
 
             $line = yield new AcceptanceResultBucket($line);

diff --git a/src/CSV/Safe/Loader.php b/src/CSV/Safe/Loader.php
@@ -42,7 +42,8 @@ public function load(): \Generator
             );
         }
 
-        while ($line) {
+        /* @phpstan-ignore-next-line */
+        while (true) {
             try {
                 $this->writer->addRow($this->orderColumns($headers, $line));
             } catch (IOException|WriterNotOpenedException $exception) {
@@ -52,6 +53,7 @@ public function load(): \Generator
                     $exception,
                     $line
                 );
+                continue;
             }
 
             $line = yield new AcceptanceResultBucket($line);

diff --git a/src/Sheet/FingersCrossed/Loader.php b/src/Sheet/FingersCrossed/Loader.php
@@ -46,7 +46,8 @@ public function load(): \Generator
             );
         }
 
-        while ($line) {
+        /* @phpstan-ignore-next-line */
+        while (true) {
             try {
                 $this->writer->addRow(
                     new Row(array_map(fn ($value) => new Cell($value), $line), null)
@@ -58,6 +59,7 @@ public function load(): \Generator
                     $exception,
                     $line
                 );
+                continue;
             }
 
             $line = yield new AcceptanceResultBucket($line);

diff --git a/src/Sheet/Safe/Loader.php b/src/Sheet/Safe/Loader.php
@@ -46,7 +46,8 @@ public function load(): \Generator
             );
         }
 
-        while ($line) {
+        /* @phpstan-ignore-next-line */
+        while (true) {
             try {
                 $this->writer->addRow($this->orderColumns($headers, $line));
             } catch (IOException|WriterNotOpenedException $exception) {
@@ -56,6 +57,7 @@ public function load(): \Generator
                     $exception,
                     $line
                 );
+                continue;
             }
 
             $line = yield new AcceptanceResultBucket($line);