Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated php-etl contract versions #14

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Conversation

sebprt
Copy link
Contributor

@sebprt sebprt commented Nov 20, 2023

No description provided.

@sebprt sebprt added the GTM label Nov 20, 2023
@sebprt sebprt requested a review from gplanchat November 20, 2023 14:09
@sebprt sebprt self-assigned this Nov 20, 2023
@sebprt sebprt force-pushed the feature/update-contracts branch from 59df091 to 8caab8a Compare November 22, 2023 09:16
@sebprt sebprt added WIP and removed GTM labels Nov 22, 2023
Copy link
Collaborator

@gplanchat gplanchat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si PHPStan niveau 5 passe, il faut mettre ce niveau par défaut dans la CI et mettre à jour le README.

src/CSV/FingersCrossed/Loader.php Outdated Show resolved Hide resolved
src/CSV/FingersCrossed/Loader.php Show resolved Hide resolved
src/Sheet/Safe/Loader.php Show resolved Hide resolved
src/Sheet/Safe/Loader.php Outdated Show resolved Hide resolved
src/Sheet/Safe/Loader.php Show resolved Hide resolved
src/Sheet/FingersCrossed/Loader.php Show resolved Hide resolved
src/Sheet/FingersCrossed/Loader.php Show resolved Hide resolved
@sebprt sebprt force-pushed the feature/update-contracts branch from 5ce45d9 to c77bdf0 Compare November 22, 2023 14:04
@gplanchat gplanchat merged commit 9a70f6d into main Nov 22, 2023
4 of 8 checks passed
@gplanchat gplanchat deleted the feature/update-contracts branch November 22, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants