Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dependency graph #122

Merged
merged 3 commits into from
Jul 28, 2016
Merged

Added dependency graph #122

merged 3 commits into from
Jul 28, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 28, 2016

This is related to #82

screen shot 2016-07-28 at 16 31 31

@@ -80,6 +80,7 @@ for discussion around a future HTTP client PSR.
:hidden:
:caption: Components

components/dependency-graph
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the dependency graph is not a component itself :-)

i would prefer to embed this into some architecture background document that also has some text and not only the image.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey =)

If you do not mind I'll give this issue to you

@Nyholm
Copy link
Member Author

Nyholm commented Jul 28, 2016

This PR does only include the image. Can the page and texts be added separately? Should I also upload the source?

@joelwurtz
Copy link
Member

👍 for the source

Page and texts can be done in another PR IMO

@Nyholm Nyholm merged commit 4720a5d into php-http:master Jul 28, 2016
@Nyholm Nyholm deleted the dependency branch July 28, 2016 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants