Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read xml from memory #10

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Read xml from memory #10

merged 1 commit into from
Jun 13, 2024

Conversation

veewee
Copy link
Member

@veewee veewee commented Jun 12, 2024

Q A
Type improvement
BC Break no
Fixed issues

Summary

This PR limits the amount of xml serializations / deserializations in between encoders.
On a rather big soap response, there is a lot of gain:

- 0.98881793022156s
+ 0.24171805381775s

1^ "Payload size"
2^ "445.0205078125KB"

@veewee veewee marked this pull request as draft June 12, 2024 14:29
@veewee veewee force-pushed the read-xml-from-memory branch 2 times, most recently from ac415e7 to 7849ab5 Compare June 13, 2024 12:33
@veewee veewee force-pushed the read-xml-from-memory branch from 7849ab5 to af4a2d7 Compare June 13, 2024 12:43
@veewee veewee marked this pull request as ready for review June 13, 2024 12:44
@veewee veewee merged commit 14754ce into php-soap:main Jun 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant