Improve operation and param element generation #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
commented
Jul 19, 2024
| @@ -38,7 +38,7 @@ protected function calculateParam(): mixed | |||
| #[Test] | |||
| public function it_is_compatible_with_phps_encoding() | |||
| { | |||
| static::markTestSkipped('Literal document seems about right - yet php soap uses the type instead of the part name. Not sure what to do here yet.'); | |||
| static::markTestSkipped('Literal document seems about right - it seems to be taking the param name instead of the complextype name though. Not sure what to do here yet.'); | |||
There was a problem hiding this comment.
TODO : Check spec for literal encoding on what to do here.
Current assumption:
- if the type is a complex type, the parameter name is being used (unqualified)
- if the type is an element type, the element info is being used (qualified)
There was a problem hiding this comment.
Cant seem to figure out why it is encoding it like this. SOAP-UI is also using the message part name. Leaving it for now.
veewee
force-pushed
the
fix-operation-message-names
branch
from
5a2f04d to
21772ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Summary